[Issue 1083] New - Locks-and-latches plugin not locking properly

9 messages

[Issue 1083] New - Locks-and-latches plugin not locking properly

Reply Threaded

https://hudson.dev.java.net/issues/show_bug.cgi?id=1083
Issue #|1083
Summary|Locks-and-latches plugin not locking properly
Component|hudson
Version|current
Platform|All
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|ENHANCEMENT
Priority|P3
Subcomponent|plugin
Assigned to|stephenconnolly
Reported by|crleblanc

------- Additional comments from [hidden email] Mon Dec 10 22:13:16 +0000 2007 -------
The locks-and-latches plugin fails to lock each slave when running a matrix job
running on several slaves. Instead, the job is run on each slave in parallel.

Stephen Connolly has posted these follow ups on the mailing list:

"I think the other issue is a bug in ResourceLists in the core of
Hudson. I'll write a unit test to check my theory and maybe commit
the fix. I have a work-around in the Locks and Latches plugin that
_should_ detect when the bug is fixed in the core and disable it's
workaround!"

"I have filed an issue and checked-in JUnit tests with regards to the
resources issue:

https://hudson.dev.java.net/issues/show_bug.cgi?id=1080

When these are fixed that _might_ fix the matrix issue. The RFE may
still need some work, if somebody can raise the RFE that way I'll
remember to get back to it when the core is fixed.

-Stephen"

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

dvrzalik

[Issue 1083] Locks-and-latches plugin not locking properly

Reply Threaded

https://hudson.dev.java.net/issues/show_bug.cgi?id=1083

User dvrzalik changed the following:

What |Old value |New value
================================================================================
CC|'' |'dvrzalik'
--------------------------------------------------------------------------------
Issue type|ENHANCEMENT |DEFECT
--------------------------------------------------------------------------------
Priority|P3 |P2
--------------------------------------------------------------------------------
Subcomponent|plugin |matrix
--------------------------------------------------------------------------------

------- Additional comments from [hidden email] Tue Feb 19 13:09:57 +0000 2008 -------
I can see at least two problems which prevent the Locks plugin from working with
matrix projects:
1) Project.getResourceActivities() method refers to Project.buildWrappers field.
MatrixConfiguration extends Project, but uses wrappers and publishers configured
in MatrixProject, which means that hudson scheduler doesn't know their
resources. Solution could be to modify Project.getResourceActivities() to
reflect child's wrappers, e.g. like this:
activities.addAll(Util.filter(getBuildWrappers().values(),ResourceActivity.class));
2) Another problem is that checking for occupied resources is done after the
task enters the executor. See issue #1122.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

dvrzalik