Hudson › Hudson issues

[Issue 3597] New - Improve cobertura plugin memory usage when drawing trend graphs

9 messages

davidmc24

[Issue 3597] New - Improve cobertura plugin memory usage when drawing trend graphs

Reply Threaded

https://hudson.dev.java.net/issues/show_bug.cgi?id=3597
Issue #|3597
Summary|Improve cobertura plugin memory usage when drawing tre
|nd graphs
Component|hudson
Version|current
Platform|All
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|cobertura
Assigned to|stephenconnolly
Reported by|davidmc24

------- Additional comments from [hidden email] Wed Apr 29 15:01:43 +0000 2009 -------
The majority of the memory usage of the Cobertura plugin is currently in the
"paint" object. However, the "paint" object is only used during initial
publishing, not during subsequent trend change generation or metrics display.

This patch pulls the "paint" support out of CoverageResult into a subclass,
PaintedCoverageResult. The parser is modified to return the basic
CoverageResult by default, and adds methods to request a PaintedCoverageResult
(which are used by the publishers).

After this patch, the Cobertura plugin will still be slow when large coverage
files and/or lots of builds are in play, but it should throw OutOfMemoryErrors
on trend graph generation less commonly.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

davidmc24

[Issue 3597] Improve cobertura plugin memory usage when drawing trend graphs

Reply Threaded

https://hudson.dev.java.net/issues/show_bug.cgi?id=3597

User davidmc24 changed the following:

What |Old value |New value
================================================================================
Attachment is patch| |Created an attachment (id=
| |682)
Patch as described

--------------------------------------------------------------------------------

------- Additional comments from [hidden email] Wed Apr 29 15:05:27 +0000 2009 -------
Created an attachment (id=682)
Patch as described

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

davidmc24

[Issue 3597] Improve cobertura plugin memory usage when drawing trend graphs

Reply Threaded

In reply to this post by davidmc24

https://hudson.dev.java.net/issues/show_bug.cgi?id=3597

User davidmc24 changed the following:

What |Old value |New value
================================================================================
Assigned to|stephenconnolly |davidmc24
--------------------------------------------------------------------------------
QA contact|stephenconnolly |davidmc24
--------------------------------------------------------------------------------

------- Additional comments from [hidden email] Mon May 11 19:32:12 +0000 2009 -------
Reassign to myself

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

davidmc24

[Issue 3597] Improve cobertura plugin memory usage when drawing trend graphs

Reply Threaded

In reply to this post by davidmc24

https://hudson.dev.java.net/issues/show_bug.cgi?id=3597

User davidmc24 changed the following:

What |Old value |New value
================================================================================
Status|NEW |STARTED
--------------------------------------------------------------------------------

------- Additional comments from [hidden email] Mon May 11 19:43:45 +0000 2009 -------
Starting work on applying the patch

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Issue 3597] Improve cobertura plugin memory usage when drawing trend graphs

Reply Threaded

In reply to this post by davidmc24

https://hudson.dev.java.net/issues/show_bug.cgi?id=3597

User scm_issue_link changed the following:

What |Old value |New value
================================================================================
Status|STARTED |RESOLVED
--------------------------------------------------------------------------------
Resolution| |FIXED
--------------------------------------------------------------------------------

------- Additional comments from [hidden email] Mon May 11 20:23:00 +0000 2009 -------
Code changed in hudson
User: : davidmc24
Path:
trunk/hudson/plugins/cobertura/pom.xml
trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaCoverageParser.java
trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaPublisher.java
trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/MavenCoberturaPublisher.java
trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/targets/CoverageResult.java
trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/targets/PaintedCoverageResult.java
trunk/hudson/plugins/cobertura/src/test/java/hudson/plugins/cobertura/CoberturaCoverageParserTest.java
trunk/hudson/plugins/cobertura/src/test/java/hudson/plugins/cobertura/CoverageResultTest.java
trunk/hudson/plugins/cobertura/src/test/resources/hudson/plugins/cobertura/coverage-with-lots-of-data.xml
http://fisheye4.cenqua.com/changelog/hudson/?cs=17956
Log:
[FIXED HUDSON-3597] - Apply patch to cobertura plugin to reduce memory usage. Should be included in next release of the plugin (0.8.7).

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

davidmc24

[Issue 3597] Improve cobertura plugin memory usage when drawing trend graphs

Reply Threaded

In reply to this post by davidmc24

https://hudson.dev.java.net/issues/show_bug.cgi?id=3597

User davidmc24 changed the following:

What |Old value |New value
================================================================================
Status|RESOLVED |CLOSED
--------------------------------------------------------------------------------

------- Additional comments from [hidden email] Thu Jun 4 05:09:33 +0000 2009 -------
Included in cobertura plugin version 0.8.7, which is now released.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

davidmc24

[Issue 3597] Improve cobertura plugin memory usage when drawing trend graphs

Reply Threaded

In reply to this post by davidmc24

https://hudson.dev.java.net/issues/show_bug.cgi?id=3597

User davidmc24 changed the following:

What |Old value |New value
================================================================================
Status|CLOSED |REOPENED
--------------------------------------------------------------------------------
Resolution|FIXED |
--------------------------------------------------------------------------------

------- Additional comments from [hidden email] Thu Jun 11 04:37:30 +0000 2009 -------
This "fix" breaks source code highlighting. Further analysis needed. For now, back out the change.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Issue 3597] Improve cobertura plugin memory usage when drawing trend graphs

Reply Threaded

In reply to this post by davidmc24

https://hudson.dev.java.net/issues/show_bug.cgi?id=3597

------- Additional comments from [hidden email] Thu Jun 11 04:54:35 +0000 2009 -------
Code changed in hudson
User: : davidmc24
Path:
trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaCoverageParser.java
trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaPublisher.java
trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/MavenCoberturaPublisher.java
trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/targets/CoverageResult.java
trunk/hudson/plugins/cobertura/src/test/java/hudson/plugins/cobertura/CoberturaCoverageParserTest.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=18797
Log:
[HUDSON-3597] Back out the changes to attempt to reduce Cobertura plugin memory usage, since they had unintended side-effects. Should be included in the next release of the plugin (0.8.8).

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

mdonohue

[Issue 3597] Improve cobertura plugin memory usage when drawing trend graphs

Reply Threaded

In reply to this post by davidmc24

https://hudson.dev.java.net/issues/show_bug.cgi?id=3597

------- Additional comments from [hidden email] Sun Nov 8 04:15:55 +0000 2009 -------
*** Issue 4795 has been marked as a duplicate of this issue. ***

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]