[Issue 4461] New - Hg polling can hang indefinitely

[jglick-2]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461
                 Issue #|4461
                 Summary|Hg polling can hang indefinitely
               Component|hudson
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|mercurial
             Assigned to|jglick
             Reported by|jglick






------- Additional comments from [hidden email] Tue Sep 15 00:14:53 +0000 2009 -------
If the hg process for e.g. 'hg incoming' hangs for whatever reason (network
issues?), Hudson will just cease to build that job. The only indication is the
"There are more SCM polling activities scheduled than handled" warning.

Probably there should be some timeout on polling operations, such as 1 hour.
Builds can already be set to timeout so these probably need no special handling.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[jglick-2]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461



User jglick changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|''                        |'mzlamal'
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Tue Sep 15 00:15:47 +0000 2009 -------
Example:

http://deadlock.netbeans.org/hudson/job/NB-Core-Build/scmPollLog/

says

Last Mercurial Polling Log

Started on Sep 11, 2009 11:31:31 PM [three days ago!]
[workspace] $ hg incoming --style
/hudson/workdir/jobs/NB-Core-Build/workspace/tmp92283style


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[jglick-2]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461






------- Additional comments from [hidden email] Wed Sep 16 21:34:14 +0000 2009 -------
FWIW I captured the Hg 1.0.1 / Python 2.5 stack trace:
$PYTHON_HOME/socket.py (332): readline
$PYTHON_HOME/httplib.py (344): _read_status
$PYTHON_HOME/httplib.py (386): begin
$PYTHON_HOME/httplib.py (925): getresponse
$PYTHON_HOME/site-packages/mercurial/keepalive.py (243): do_open
$PYTHON_HOME/site-packages/mercurial/httprepo.py (107): http_open
$PYTHON_HOME/urllib2.py (354): _call_chain
$PYTHON_HOME/urllib2.py (393): _open
$PYTHON_HOME/urllib2.py (377): open
$PYTHON_HOME/urllib2.py (121): urlopen
$PYTHON_HOME/site-packages/mercurial/httprepo.py (305): do_cmd
$PYTHON_HOME/site-packages/mercurial/httprepo.py (351): do_read
$PYTHON_HOME/site-packages/mercurial/httprepo.py (367): heads
$PYTHON_HOME/site-packages/mercurial/localrepo.py (1305): findincoming
$PYTHON_HOME/site-packages/mercurial/commands.py (1598): incoming
$PYTHON_HOME/site-packages/mercurial/dispatch.py (356): <lambda>
$PYTHON_HOME/site-packages/mercurial/dispatch.py (374): checkargs
$PYTHON_HOME/site-packages/mercurial/dispatch.py (417): _runcommand
$PYTHON_HOME/site-packages/mercurial/dispatch.py (366): _dispatch
$PYTHON_HOME/site-packages/mercurial/dispatch.py (47): _runcatch
$PYTHON_HOME/site-packages/mercurial/dispatch.py (29): dispatch
$PYTHON_HOME/site-packages/mercurial/dispatch.py (20): run
bin/hg (20): <module>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[scm_issue_link]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461



User scm_issue_link changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Thu Sep 17 18:11:06 +0000 2009 -------
Code changed in hudson
User: : jglick
Path:
 trunk/hudson/plugins/mercurial/src/main/java/hudson/plugins/mercurial/MercurialSCM.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=21786
Log:
[FIXED HUDSON-4461] Kill Hg polling process after one hour, assuming it is stuck on a bad network connection.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[scm_issue_link]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461






------- Additional comments from [hidden email] Sun Sep 20 15:51:38 +0000 2009 -------
Code changed in hudson
User: : jglick
Path:
 trunk/hudson/plugins/mercurial/src/main/java/hudson/plugins/mercurial/MercurialSCM.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=21911
Log:
[HUDSON-4461] Prevent thread leak from previous fix.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[jglick-2]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461



User jglick changed the following:

                What    |Old value                 |New value
================================================================================
     IssuesThisDependsOn|                          |4513
--------------------------------------------------------------------------------




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[scm_issue_link]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461






------- Additional comments from [hidden email] Tue Sep 22 21:41:16 +0000 2009 -------
Code changed in hudson
User: : jglick
Path:
 trunk/hudson/plugins/mercurial/src/main/java/hudson/plugins/mercurial/MercurialSCM.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=22014
Log:
[FIXED HUDSON-4513] Improper implementation of timeout ([HUDSON-4461]).


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Kohsuke Kawaguchi]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461




This issue depends on issue 4513, which changed state:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[jglick-2]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461



User jglick changed the following:

                What    |Old value                 |New value
================================================================================
     IssuesThisDependsOn|4513                      |4513,4611
--------------------------------------------------------------------------------




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[scm_issue_link]

https://hudson.dev.java.net/issues/show_bug.cgi?id=4461




This issue depends on issue 4611, which changed state:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]