[JIRA] Created: (APF-1144) checkstyle errors (focus on struts 2.0 basic)

5 messages Options
Embed this post
Permalink
AppFuse - Issues mailing list

[JIRA] Created: (APF-1144) checkstyle errors (focus on struts 2.0 basic)

Reply Threaded More More options
Print post
Permalink
checkstyle errors (focus on struts 2.0 basic)
---------------------------------------------

                 Key: APF-1144
                 URL: http://issues.appfuse.org/browse/APF-1144
             Project: AppFuse
          Issue Type: Bug
    Affects Versions: 2.0.2
         Environment: all
            Reporter: tibi
            Assignee: Matt Raible
            Priority: Minor
         Attachments: patchCheckstyleFixStruts.txt

there are quite some checkstyle errors. if fixed them in my project and ported them to the appfuse project. attached there is a patch.

the checkstyle used is the https://appfuse.dev.java.net/checkstyle.xml
i needed to change the lineLength to ignore javadoc with @see and long word:

<module name="LineLength">
            <property name="max" value="120"/>
            <!-- ignore rows starting with a * @see and long word-->
            <property name="ignorePattern" value="^ *\* \@see *[^ ]+$"/>
</module>



--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.appfuse.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

AppFuse - Issues mailing list

[JIRA] Updated: (APF-1144) checkstyle errors (focus on struts 2.0 basic)

Reply Threaded More More options
Print post
Permalink

     [ http://issues.appfuse.org/browse/APF-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Raible updated APF-1144:
-----------------------------

    Fix Version/s: 2.1
      Component/s: Documentation

> checkstyle errors (focus on struts 2.0 basic)
> ---------------------------------------------
>
>                 Key: APF-1144
>                 URL: http://issues.appfuse.org/browse/APF-1144
>             Project: AppFuse
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 2.0.2
>         Environment: all
>            Reporter: tibi
>            Assignee: Matt Raible
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: patchCheckstyleFixStruts.txt
>
>
> there are quite some checkstyle errors. if fixed them in my project and ported them to the appfuse project. attached there is a patch.
> the checkstyle used is the https://appfuse.dev.java.net/checkstyle.xml
> i needed to change the lineLength to ignore javadoc with @see and long word:
> <module name="LineLength">
>             <property name="max" value="120"/>
>             <!-- ignore rows starting with a * @see and long word-->
>             <property name="ignorePattern" value="^ *\* \@see *[^ ]+$"/>
> </module>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.appfuse.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

AppFuse - Issues mailing list

[JIRA] Commented: (APF-1144) checkstyle errors (focus on struts 2.0 basic)

Reply Threaded More More options
Print post
Permalink
In reply to this post by AppFuse - Issues mailing list

    [ http://issues.appfuse.org/browse/APF-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12660 ]

tibi  commented on APF-1144:
----------------------------

on my new project i applied the my own patch (from attached file) and there are a lot less but still errors.
some how i missed some in the patch :(

i will make a new patch on request after this one has been integrated matt send me an email: [hidden email]

> checkstyle errors (focus on struts 2.0 basic)
> ---------------------------------------------
>
>                 Key: APF-1144
>                 URL: http://issues.appfuse.org/browse/APF-1144
>             Project: AppFuse
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 2.0.2
>         Environment: all
>            Reporter: tibi
>            Assignee: Matt Raible
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: patchCheckstyleFixStruts.txt
>
>
> there are quite some checkstyle errors. if fixed them in my project and ported them to the appfuse project. attached there is a patch.
> the checkstyle used is the https://appfuse.dev.java.net/checkstyle.xml
> i needed to change the lineLength to ignore javadoc with @see and long word:
> <module name="LineLength">
>             <property name="max" value="120"/>
>             <!-- ignore rows starting with a * @see and long word-->
>             <property name="ignorePattern" value="^ *\* \@see *[^ ]+$"/>
> </module>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.appfuse.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

AppFuse - Issues mailing list

[JIRA] Updated: (APF-1144) checkstyle errors (focus on struts 2.0 basic)

Reply Threaded More More options
Print post
Permalink
In reply to this post by AppFuse - Issues mailing list

     [ http://issues.appfuse.org/browse/APF-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

tibi  updated APF-1144:
-----------------------

    Attachment: eclipse_code_formatter.xml

after the patch i ended up with still 66 checkstyle errors

after running format from eclipse i was left with 23 errors.

i attached my eclipse formatter

> checkstyle errors (focus on struts 2.0 basic)
> ---------------------------------------------
>
>                 Key: APF-1144
>                 URL: http://issues.appfuse.org/browse/APF-1144
>             Project: AppFuse
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 2.0.2
>         Environment: all
>            Reporter: tibi
>            Assignee: Matt Raible
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: eclipse_code_formatter.xml, patchCheckstyleFixStruts.txt
>
>
> there are quite some checkstyle errors. if fixed them in my project and ported them to the appfuse project. attached there is a patch.
> the checkstyle used is the https://appfuse.dev.java.net/checkstyle.xml
> i needed to change the lineLength to ignore javadoc with @see and long word:
> <module name="LineLength">
>             <property name="max" value="120"/>
>             <!-- ignore rows starting with a * @see and long word-->
>             <property name="ignorePattern" value="^ *\* \@see *[^ ]+$"/>
> </module>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.appfuse.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

AppFuse - Issues mailing list

[JIRA] Resolved: (APF-1144) checkstyle errors (focus on struts 2.0 basic)

Reply Threaded More More options
Print post
Permalink
In reply to this post by AppFuse - Issues mailing list

     [ http://issues.appfuse.org/browse/APF-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Raible resolved APF-1144.
------------------------------

    Resolution: Fixed

> checkstyle errors (focus on struts 2.0 basic)
> ---------------------------------------------
>
>                 Key: APF-1144
>                 URL: http://issues.appfuse.org/browse/APF-1144
>             Project: AppFuse
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 2.0.2
>         Environment: all
>            Reporter: tibi
>            Assignee: Matt Raible
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: eclipse_code_formatter.xml, patchCheckstyleFixStruts.txt
>
>
> there are quite some checkstyle errors. if fixed them in my project and ported them to the appfuse project. attached there is a patch.
> the checkstyle used is the https://appfuse.dev.java.net/checkstyle.xml
> i needed to change the lineLength to ignore javadoc with @see and long word:
> <module name="LineLength">
>             <property name="max" value="120"/>
>             <!-- ignore rows starting with a * @see and long word-->
>             <property name="ignorePattern" value="^ *\* \@see *[^ ]+$"/>
> </module>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.appfuse.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]