[JIRA] Created: (APF-890) Creation of a separate appfuse-dao module for DAO api (interfaces)

6 messages

[JIRA] Created: (APF-890) Creation of a separate appfuse-dao module for DAO api (interfaces)

Reply Threaded

Creation of a separate appfuse-dao module for DAO api (interfaces)
------------------------------------------------------------------

Key: APF-890
URL: http://issues.appfuse.org/browse/APF-890
Project: AppFuse
Issue Type: Improvement
Components: Build, Test, or Deploy Process
Reporter: Marcello Teodori
Assignee: Matt Raible

The GenericDao and UniversalDao interfaces source files are duplicated across all three DAO implementation maven projects.
They could be handled more easily if they were a separate project to be used as additional dependency from those three projects, allowing easier customization for the introduction of, say, generic finder methods, like the ones discussed in: http://www.nabble.com/Proposal-for-a-Finder-implementation-in-DAOs-for-AppFuse-t4159990s2369.html

There could be room for a wiki page that explains how to add custom generic DAO behaviour to these base classes.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.appfuse.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

AppFuse - Issues mailing list

[JIRA] Updated: (APF-890) Creation of a separate appfuse-dao module for DAO api (interfaces)

Reply Threaded

[ http://issues.appfuse.org/browse/APF-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Raible updated APF-890:
----------------------------

Affects Version/s: 2.0-RC1
Fix Version/s: 2.0.1

> Creation of a separate appfuse-dao module for DAO api (interfaces)
> ------------------------------------------------------------------
>
> Key: APF-890
> URL: http://issues.appfuse.org/browse/APF-890
> Project: AppFuse
> Issue Type: Improvement
> Components: Build, Test, or Deploy Process
> Affects Versions: 2.0-RC1
> Reporter: Marcello Teodori
> Assignee: Matt Raible
> Fix For: 2.0.1
>
>
> The GenericDao and UniversalDao interfaces source files are duplicated across all three DAO implementation maven projects.
> They could be handled more easily if they were a separate project to be used as additional dependency from those three projects, allowing easier customization for the introduction of, say, generic finder methods, like the ones discussed in: http://www.nabble.com/Proposal-for-a-Finder-implementation-in-DAOs-for-AppFuse-t4159990s2369.html
> There could be room for a wiki page that explains how to add custom generic DAO behaviour to these base classes.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.appfuse.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

AppFuse - Issues mailing list

[JIRA] Commented: (APF-890) Creation of a separate appfuse-dao module for DAO api (interfaces)

Reply Threaded

In reply to this post by AppFuse - Issues mailing list

[ http://issues.appfuse.org/browse/APF-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12128 ]

Matt Raible commented on APF-890:
---------------------------------

Doesn't the current way things are arranged allow for more flexibility? For example, we could add generic finder methods for JPA and Hibernate, but not for iBATIS. If we were to implement this, we'd *have* to implement iBATIS or throw UnsupportedOperationException. I'm afraid if we start making AppFuse too modular, it can easily get out of hand and we'll end up with things like appfuse-aop, appfuse-security, etc. where each is a feature you can add to your app.

Maybe it's a good idea, who knows. However, this seems like a low priority issue. I'd rather 1) implement generic finders in all 3 and 2) if we need to consolidate, move them into data-common.

AppFuse - Issues mailing list

[JIRA] Commented: (APF-890) Creation of a separate appfuse-dao module for DAO api (interfaces)

Reply Threaded

In reply to this post by AppFuse - Issues mailing list

[ http://issues.appfuse.org/browse/APF-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12140 ]

Marcello Teodori commented on APF-890:
--------------------------------------

My issue was mostly about removing the current duplication of each of the named interfaces:

./data/hibernate/src/main/java/org/appfuse/dao/GenericDao.java
./data/ibatis/src/main/java/org/appfuse/dao/GenericDao.java
./data/jpa/src/main/java/org/appfuse/dao/GenericDao.java

./data/hibernate/src/main/java/org/appfuse/dao/UniversalDao.java
./data/ibatis/src/main/java/org/appfuse/dao/UniversalDao.java
./data/jpa/src/main/java/org/appfuse/dao/UniversalDao.java

by creating a new maven module or adding a single copy to data/common,
than to add generic finder methods to those interfaces.

Unfortunately I don't have any iBATIS experience, so I cannot be helpful on the subject of developing generic finder methods for that specific framework, but I would prefer the GenericDAO and UniversalDAO to have methods that are available across all implementations, otherwise it would be impossible to switch.

AppFuse - Issues mailing list

[JIRA] Updated: (APF-890) Creation of a separate appfuse-dao module for DAO api (interfaces)

Reply Threaded

In reply to this post by AppFuse - Issues mailing list

> Creation of a separate appfuse-dao module for DAO api (interfaces)
> ------------------------------------------------------------------
>
> Key: APF-890
> URL: http://issues.appfuse.org/browse/APF-890
> Project: AppFuse
> Issue Type: Improvement
> Components: Build, Test, or Deploy Process
> Affects Versions: 2.0-RC1
> Reporter: Marcello Teodori
> Assignee: Matt Raible
> Fix For: 2.1
>
>
> The GenericDao and UniversalDao interfaces source files are duplicated across all three DAO implementation maven projects.
> They could be handled more easily if they were a separate project to be used as additional dependency from those three projects, allowing easier customization for the introduction of, say, generic finder methods, like the ones discussed in: http://www.nabble.com/Proposal-for-a-Finder-implementation-in-DAOs-for-AppFuse-t4159990s2369.html
> There could be room for a wiki page that explains how to add custom generic DAO behaviour to these base classes.

AppFuse - Issues mailing list

[JIRA] Updated: (APF-890) Creation of a separate appfuse-dao module for DAO api (interfaces)

Reply Threaded

In reply to this post by AppFuse - Issues mailing list

> Creation of a separate appfuse-dao module for DAO api (interfaces)
> ------------------------------------------------------------------
>
> Key: APF-890
> URL: http://issues.appfuse.org/browse/APF-890
> Project: AppFuse
> Issue Type: Improvement
> Components: Build, Test, or Deploy Process
> Affects Versions: 2.0-RC1
> Reporter: Marcello Teodori
> Assignee: Matt Raible
> Fix For: 2.1.0-M2
>
>
> The GenericDao and UniversalDao interfaces source files are duplicated across all three DAO implementation maven projects.
> They could be handled more easily if they were a separate project to be used as additional dependency from those three projects, allowing easier customization for the introduction of, say, generic finder methods, like the ones discussed in: http://www.nabble.com/Proposal-for-a-Finder-implementation-in-DAOs-for-AppFuse-t4159990s2369.html
> There could be room for a wiki page that explains how to add custom generic DAO behaviour to these base classes.