[JIRA] Updated: (APF-349) remove confirmPassowrd from User domain class

1 message Options
Embed this post
Permalink
AppFuse - Issues mailing list

[JIRA] Updated: (APF-349) remove confirmPassowrd from User domain class

Reply Threaded More More options
Print post
Permalink

     [ http://issues.appfuse.org/browse/APF-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Raible updated APF-349:
----------------------------

    Fix Version/s:     (was: 2.1.0-M1)
                   2.1.0-M2

> remove confirmPassowrd from User domain class
> ---------------------------------------------
>
>                 Key: APF-349
>                 URL: http://issues.appfuse.org/browse/APF-349
>             Project: AppFuse
>          Issue Type: Improvement
>          Components: Web - General
>    Affects Versions: 1.9.1
>            Reporter: Sanjiv Jivan
>            Priority: Minor
>             Fix For: 2.1.0-M2
>
>
> Remove "confirmPassword" member from the User doamin class.
> ---------- Forwarded message ----------
> From: Matt Raible <[hidden email]>
> Date: May 7, 2006 4:29 PM
> Subject: Re: [appfuse-user] confirmPassword in User class
> To: [hidden email]
> That sounds reasonable enough: Struts and Spring would read from the
> request, JSF, Tapestry and WebWork could have an extra property +
> getter/setter.  If you'd like to enter an issue for this in JIRA,
> that'd be great.  Please also note the release you'd like to see this
> fixed in.
> Matt
> On 5/7/06, Sanjiv Jivan <[hidden email]> wrote:
> > I was thinking that for request-response based frameworks, the controller
> > could directly read from the HttpServletRequest instead of having a wrapper
> > object. For JSF, it could bind to an additional field on the command class.
> >
> > Regarding validation, this check for equality could be done manually in the
> > controller instead of going through a validation framework.
> >
> > I'm terrible at typing so I like the confirm password field.
> >
> >
> >  On 5/7/06, Matt Raible <[hidden email]> wrote:
> > >
> >  I agree, but if we move it to the web layer, we'd have to create a
> > wrapper around the user class (at least to re-use many of the
> > validation frameworks).  Do you have any ideas on how to refactor this
> > to make it a web-tier only feature?  Also, I'm open to removing it
> > altogether as I tend to think confirming a password is sometimes a
> > silly feature.  KISS.
> >
> > Matt
> >
> > On 5/7/06, Sanjiv Jivan <[hidden email]> wrote:
> >  >
> > > Does the confirmPassword member belong in the User domain class? Seems
> > like
> > > more of a web controller function to verify that the user has confirmed
> > the
> > > password. Am I missing something here?
> >  >
> > > Thanks,
> > >
> > > Sanjiv

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.appfuse.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]