Maven2 project actions

[David Vrzalik-2]

Hello,
I am facing following problem: I successfully attached an Action via
JobProperty to a free style software project. Now I'd like to do the same
with native Maven2 project, but I can't. Freestyle projects uses
updateTransientActions() to get actions from its properties, but both
MavenModule and MavenModuleSet ignore any actions (except for those obtained
from a build). Is there any particular reason why is this functionality
disabled for Maven2 projects? If not, would it be possible to enhance Maven
project classes to reflect properties actions?
Many thanks for help!

--
David Vrzalik

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Stephen Connolly-2]

David Vrzalik-2 wrote:

Is there any particular reason why is this functionality
disabled for Maven2 projects?

My understanding is that the reason why this is disabled is due to the different model of constructing a Maven 2 project.

David Vrzalik-2 wrote:

If not, would it be possible to enhance Maven
project classes to reflect properties actions?

My understanding is that it's not this simple, but Kohsuke may be able to correct me on that front.

In the interim, I'd use a free-style project with a Maven2 builder (besides that the only way to get aggregator goals such as "site" or "clover" to work)

-Stephen

[David Vrzalik-2]

On Monday 13 of August 2007 15:50:06 Stephen Connolly wrote:
> David Vrzalik-2 wrote:
> > Is there any particular reason why is this functionality
> > disabled for Maven2 projects?
>
> My understanding is that the reason why this is disabled is due to the
> different model of constructing a Maven 2 project.

It seems to me that job properties and their actions don't depend on manner in
which the project was constructed.

>
> David Vrzalik-2 wrote:
> > If not, would it be possible to enhance Maven
> > project classes to reflect properties actions?
>
> My understanding is that it's not this simple, but Kohsuke may be able to
> correct me on that front.

I don't expect this to lead in complete refactoring of Maven-related code, but
I might be wrong as well.

> In the interim, I'd use a free-style project with a Maven2 builder (besides
> that the only way to get aggregator goals such as "site" or "clover" to
> work)

Yes, I know, but some of us like the Maven type of project and I'd prefer to
make it usable in our environment if possible.
Anyway, thanks for response..



--
David Vrzalik

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Kohsuke Kawaguchi]

Sounds like you are working on a plugin. Would you be interested in
sharing them on hudson.dev.java.net with the community?

David Vrzalik wrote:
> Hello,
> I am facing following problem: I successfully attached an Action via
> JobProperty to a free style software project. Now I'd like to do the same
> with native Maven2 project, but I can't. Freestyle projects uses
> updateTransientActions() to get actions from its properties, but both
> MavenModule and MavenModuleSet ignore any actions (except for those obtained
> from a build). Is there any particular reason why is this functionality
> disabled for Maven2 projects? If not, would it be possible to enhance Maven
> project classes to reflect properties actions?

I think it's really just an oversight. When maven support was added and
existing code was refactored to split out commonality. This must have
been missed at that time.

I just committed a fix. This change will be in 1.129.

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

[David Vrzalik-2]

On Wednesday 15 of August 2007 06:51:09 Kohsuke Kawaguchi wrote:
> Sounds like you are working on a plugin. Would you be interested in
> sharing them on hudson.dev.java.net with the community?

Certainly we would. There are just few things to be done (maven2
support included ;) before the plugin is ready for public release.
For the curious: The purpose of our plugin is to solve issue #1
(https://hudson.dev.java.net/issues/show_bug.cgi?id=1).

> David Vrzalik wrote:
> > Hello,
> > I am facing following problem: I successfully attached an Action via
> > JobProperty to a free style software project. Now I'd like to do the same
> > with native Maven2 project, but I can't. Freestyle projects uses
> > updateTransientActions() to get actions from its properties, but both
> > MavenModule and MavenModuleSet ignore any actions (except for those
> > obtained from a build). Is there any particular reason why is this
> > functionality disabled for Maven2 projects? If not, would it be possible
> > to enhance Maven project classes to reflect properties actions?
>
> I think it's really just an oversight. When maven support was added and
> existing code was refactored to split out commonality. This must have
> been missed at that time.
>
> I just committed a fix. This change will be in 1.129.

Wonderful. Many thanks!

--
David Vrzalik

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Kohsuke Kawaguchi]

David Vrzalik wrote:
> On Wednesday 15 of August 2007 06:51:09 Kohsuke Kawaguchi wrote:
>> Sounds like you are working on a plugin. Would you be interested in
>> sharing them on hudson.dev.java.net with the community?
>
> Certainly we would. There are just few things to be done (maven2
> support included ;) before the plugin is ready for public release.
> For the curious: The purpose of our plugin is to solve issue #1
> (https://hudson.dev.java.net/issues/show_bug.cgi?id=1).

Really!? Wow. I really can't wait to see it. I mean, I've personally
really wanted it.


>> David Vrzalik wrote:
>> I just committed a fix. This change will be in 1.129.
>
> Wonderful. Many thanks!

My pleasure.

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]