Review Patch for Issue 4030?

[John Emmer]

I recently submitted a patch for issue 4030, which allows Maven Jobs to access the Node-Based Environment Variables.  However, I didn't feel like I understood the code well enough to submit the code directly to SVN without some review.  If someone familiar with MavenModuleSetBuild would be willing to take a look at the patch and accept it, then I would be able to start using the regular release again, instead of building locally.  Not to mention, the bug would be fixed. :)

Thanks!

--
John Emmer
Senior Software Engineer / Team Lead

Commission Junction, a division of ValueClick, Inc.
10960 Wilshire Blvd. Suite 1950 . Los Angeles, CA 90024
phone [phone]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Kohsuke Kawaguchi-2]

John Emmer wrote:
> I recently submitted a patch for issue 4030, which allows Maven Jobs to
> access the Node-Based Environment Variables.  However, I didn't feel
> like I understood the code well enough to submit the code directly to
> SVN without some review.  If someone familiar with MavenModuleSetBuild
> would be willing to take a look at the patch and accept it, then I would
> be able to start using the regular release again, instead of building
> locally.  Not to mention, the bug would be fixed. :)

My apologies for a delay. I'm looking at it right now.

--
Kohsuke Kawaguchi
Sun Microsystems                   http://weblogs.java.net/blog/kohsuke/