[jira] Created: (JCR-2392) [patch] QValueFactoryImpl.equals doesn't do compare correctly

[patch] QValueFactoryImpl.equals doesn't do compare correctly
-------------------------------------------------------------

                 Key: JCR-2392
                 URL: https://issues.apache.org/jira/browse/JCR-2392
             Project: Jackrabbit Content Repository
          Issue Type: Bug
          Components: jackrabbit-spi2dav
    Affects Versions: 1.6.0
            Reporter: Dave Brosius
            Priority: Minor
             Fix For: 1.6.1
         Attachments: equals_fix.diff

equals compares it's uri to it's own uri, as poosed to the other one.

                 // for both the value has not been loaded yet
                 if (!initialized) {
                     if (other.uri != null) {
-                        return uri.equals(uri);
+                        return other.uri.equals(uri);
                     } else {
                         // need to load the binary value in order to be able
                         // to compare the 2 values.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated JCR-2392:
------------------------------

    Status: In Progress  (was: Patch Available)

> [patch] QValueFactoryImpl.equals doesn't do compare correctly
> -------------------------------------------------------------
>
>                 Key: JCR-2392
>                 URL: https://issues.apache.org/jira/browse/JCR-2392
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav
>    Affects Versions: 1.6.0
>            Reporter: Dave Brosius
>            Priority: Minor
>             Fix For: 1.6.1
>
>         Attachments: equals_fix.diff
>
>
> equals compares it's uri to it's own uri, as poosed to the other one.
>                  // for both the value has not been loaded yet
>                  if (!initialized) {
>                      if (other.uri != null) {
> -                        return uri.equals(uri);
> +                        return other.uri.equals(uri);
>                      } else {
>                          // need to load the binary value in order to be able
>                          // to compare the 2 values.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated JCR-2392:
------------------------------

    Attachment: equals_fix.diff

> [patch] QValueFactoryImpl.equals doesn't do compare correctly
> -------------------------------------------------------------
>
>                 Key: JCR-2392
>                 URL: https://issues.apache.org/jira/browse/JCR-2392
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav
>    Affects Versions: 1.6.0
>            Reporter: Dave Brosius
>            Priority: Minor
>             Fix For: 1.6.1
>
>         Attachments: equals_fix.diff
>
>
> equals compares it's uri to it's own uri, as poosed to the other one.
>                  // for both the value has not been loaded yet
>                  if (!initialized) {
>                      if (other.uri != null) {
> -                        return uri.equals(uri);
> +                        return other.uri.equals(uri);
>                      } else {
>                          // need to load the binary value in order to be able
>                          // to compare the 2 values.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated JCR-2392:
------------------------------

    Status: Patch Available  (was: Open)

> [patch] QValueFactoryImpl.equals doesn't do compare correctly
> -------------------------------------------------------------
>
>                 Key: JCR-2392
>                 URL: https://issues.apache.org/jira/browse/JCR-2392
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav
>    Affects Versions: 1.6.0
>            Reporter: Dave Brosius
>            Priority: Minor
>             Fix For: 1.6.1
>
>         Attachments: equals_fix.diff
>
>
> equals compares it's uri to it's own uri, as poosed to the other one.
>                  // for both the value has not been loaded yet
>                  if (!initialized) {
>                      if (other.uri != null) {
> -                        return uri.equals(uri);
> +                        return other.uri.equals(uri);
>                      } else {
>                          // need to load the binary value in order to be able
>                          // to compare the 2 values.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sébastien Launay reassigned JCR-2392:
-------------------------------------

    Assignee: Sébastien Launay

> [patch] QValueFactoryImpl.equals doesn't do compare correctly
> -------------------------------------------------------------
>
>                 Key: JCR-2392
>                 URL: https://issues.apache.org/jira/browse/JCR-2392
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav
>    Affects Versions: 1.6.0
>            Reporter: Dave Brosius
>            Assignee: Sébastien Launay
>            Priority: Minor
>             Fix For: 1.6.1
>
>         Attachments: equals_fix.diff
>
>
> equals compares it's uri to it's own uri, as poosed to the other one.
>                  // for both the value has not been loaded yet
>                  if (!initialized) {
>                      if (other.uri != null) {
> -                        return uri.equals(uri);
> +                        return other.uri.equals(uri);
>                      } else {
>                          // need to load the binary value in order to be able
>                          // to compare the 2 values.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sébastien Launay resolved JCR-2392.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0

Fixed in revision 881283.
Backported to 1.6 branch in revision 881289.

> [patch] QValueFactoryImpl.equals doesn't do compare correctly
> -------------------------------------------------------------
>
>                 Key: JCR-2392
>                 URL: https://issues.apache.org/jira/browse/JCR-2392
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav
>    Affects Versions: 1.6.0
>            Reporter: Dave Brosius
>            Assignee: Sébastien Launay
>            Priority: Minor
>             Fix For: 1.6.1, 2.0.0
>
>         Attachments: equals_fix.diff
>
>
> equals compares it's uri to it's own uri, as poosed to the other one.
>                  // for both the value has not been loaded yet
>                  if (!initialized) {
>                      if (other.uri != null) {
> -                        return uri.equals(uri);
> +                        return other.uri.equals(uri);
>                      } else {
>                          // need to load the binary value in order to be able
>                          // to compare the 2 values.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sébastien Launay updated JCR-2392:
----------------------------------

    Affects Version/s: 2.0-beta1

Thanks for the patch.

> [patch] QValueFactoryImpl.equals doesn't do compare correctly
> -------------------------------------------------------------
>
>                 Key: JCR-2392
>                 URL: https://issues.apache.org/jira/browse/JCR-2392
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav
>    Affects Versions: 1.6.0, 2.0-beta1
>            Reporter: Dave Brosius
>            Assignee: Sébastien Launay
>            Priority: Minor
>             Fix For: 1.6.1, 2.0.0
>
>         Attachments: equals_fix.diff
>
>
> equals compares it's uri to it's own uri, as poosed to the other one.
>                  // for both the value has not been loaded yet
>                  if (!initialized) {
>                      if (other.uri != null) {
> -                        return uri.equals(uri);
> +                        return other.uri.equals(uri);
>                      } else {
>                          // need to load the binary value in order to be able
>                          // to compare the 2 values.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.