[jira] Created: (LANG-493) Remove code that does hold enough value to remain

8 messages

[jira] Created: (LANG-493) Remove code that does hold enough value to remain

Reply Threaded

Remove code that does hold enough value to remain
-------------------------------------------------

Key: LANG-493
URL: https://issues.apache.org/jira/browse/LANG-493
Project: Commons Lang
Issue Type: Task
Reporter: Henri Yandell
Fix For: 3.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

JIRA jira@apache.org

[jira] Commented: (LANG-493) Remove code that does hold enough value to remain

Reply Threaded

[ https://issues.apache.org/jira/browse/LANG-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682121#action_12682121 ]

Henri Yandell commented on LANG-493:
------------------------------------

JVMRandom removed (following consensus on list). RandomUtils also removed as it is nothing but a wrapper on JVMRandom and a set of nextInt(r) { r.nextInt() } type calls.

Moved to backcompat in 754599 and 754600.

> Remove code that does hold enough value to remain
> -------------------------------------------------
>
> Key: LANG-493
> URL: https://issues.apache.org/jira/browse/LANG-493
> Project: Commons Lang
> Issue Type: Task
> Reporter: Henri Yandell
> Fix For: 3.0
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

JIRA jira@apache.org

[jira] Commented: (LANG-493) Remove code that does hold enough value to remain

Reply Threaded

In reply to this post by JIRA jira@apache.org

[ https://issues.apache.org/jira/browse/LANG-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682122#action_12682122 ]

Henri Yandell commented on LANG-493:
------------------------------------

Tests moved in 754601.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

JIRA jira@apache.org

[jira] Commented: (LANG-493) Remove code that does hold enough value to remain

Reply Threaded

In reply to this post by JIRA jira@apache.org

[ https://issues.apache.org/jira/browse/LANG-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682123#action_12682123 ]

Henri Yandell commented on LANG-493:
------------------------------------

Fraction proposed on list for removal. Consensus is for it to remain.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

JIRA jira@apache.org

[jira] Commented: (LANG-493) Remove code that does hold enough value to remain

Reply Threaded

In reply to this post by JIRA jira@apache.org

[ https://issues.apache.org/jira/browse/LANG-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722304#action_12722304 ]

Henri Yandell commented on LANG-493:
------------------------------------

Removing StringEscapeUtils.escapeSql. All it does is translate apostrophes to two apostrophes, which is not worth the method unless more is implemented. This is also bad in that it is encouraging people to not use PreparedStatements, which generally should be the item used until there is a reason not to.

Removed in r786942.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

JIRA jira@apache.org

[jira] Commented: (LANG-493) Remove code that does hold enough value to remain

Reply Threaded

In reply to this post by JIRA jira@apache.org

[ https://issues.apache.org/jira/browse/LANG-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733401#action_12733401 ]

Henri Yandell commented on LANG-493:
------------------------------------

Removing Exception classes that don't really bring enough to the codebase:

NullArgumentException - r796064.
UnhandledException - r796065.
NotImplementedException - r796066.
IllegalClassException - r796067.
IncompleteArgumentException - r796068.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

JIRA jira@apache.org

[jira] Updated: (LANG-493) Remove code that does not hold enough value to remain

Reply Threaded

In reply to this post by JIRA jira@apache.org

[ https://issues.apache.org/jira/browse/LANG-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell updated LANG-493:
-------------------------------

Summary: Remove code that does not hold enough value to remain (was: Remove code that does hold enough value to remain)

> Remove code that does not hold enough value to remain
> -----------------------------------------------------
>
> Key: LANG-493
> URL: https://issues.apache.org/jira/browse/LANG-493
> Project: Commons Lang
> Issue Type: Task
> Reporter: Henri Yandell
> Fix For: 3.0
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

JIRA jira@apache.org

[jira] Commented: (LANG-493) Remove code that does not hold enough value to remain

Reply Threaded

In reply to this post by JIRA jira@apache.org

[ https://issues.apache.org/jira/browse/LANG-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772342#action_12772342 ]

Stephen Colebourne commented on LANG-493:
-----------------------------------------

commit -m "LANG-493 - Remove allElementsOfType as generics handles this pretty well now" /dev/commons/lang/src/java/org/apache/commons/lang/Validate.java /dev/commons/lang/src/test/org/apache/commons/lang/ValidateTest.java
Sending /dev/commons/lang/src/java/org/apache/commons/lang/Validate.java
Sending /dev/commons/lang/src/test/org/apache/commons/lang/ValidateTest.java
Transmitting file data ...
Committed revision 831709.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.