[jira] Created: (VFS-289) FTP connection is not released If exception is thrown out of FtpFileObject.doGetOutputStream()

FTP connection is not released If exception is thrown out of FtpFileObject.doGetOutputStream()
----------------------------------------------------------------------------------------------

                 Key: VFS-289
                 URL: https://issues.apache.org/jira/browse/VFS-289
             Project: Commons VFS
          Issue Type: Bug
    Affects Versions: Nightly Builds
            Reporter: Kirill Safonov
            Priority: Critical


When the exception is thrown while getting file output stream (i.e. due to lack of write permissions), instance of FtpClient that wat obtained by {code}ftpFs.getClient(){code} is not put back to ftpFs, so this instance will never be called disconnect(). This effectively leads to the connection never released.

This will eventually result in "FTP response 421 received. Server closed connection." due to too many open connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/VFS-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kirill Safonov updated VFS-289:
-------------------------------

    Attachment: VFS-289.patch

Patch attached

> FTP connection is not released If exception is thrown out of FtpFileObject.doGetOutputStream()
> ----------------------------------------------------------------------------------------------
>
>                 Key: VFS-289
>                 URL: https://issues.apache.org/jira/browse/VFS-289
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Kirill Safonov
>            Priority: Critical
>         Attachments: VFS-289.patch
>
>
> When the exception is thrown while getting file output stream (i.e. due to lack of write permissions), instance of FtpClient that wat obtained by {code}ftpFs.getClient(){code} is not put back to ftpFs, so this instance will never be called disconnect(). This effectively leads to the connection never released.
> This will eventually result in "FTP response 421 received. Server closed connection." due to too many open connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/VFS-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ralph Goers resolved VFS-289.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

> FTP connection is not released If exception is thrown out of FtpFileObject.doGetOutputStream()
> ----------------------------------------------------------------------------------------------
>
>                 Key: VFS-289
>                 URL: https://issues.apache.org/jira/browse/VFS-289
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Kirill Safonov
>            Priority: Critical
>             Fix For: 2.0
>
>         Attachments: VFS-289.patch
>
>
> When the exception is thrown while getting file output stream (i.e. due to lack of write permissions), instance of FtpClient that wat obtained by {code}ftpFs.getClient(){code} is not put back to ftpFs, so this instance will never be called disconnect(). This effectively leads to the connection never released.
> This will eventually result in "FTP response 421 received. Server closed connection." due to too many open connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/VFS-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773115#action_12773115 ]

Ralph Goers commented on VFS-289:
---------------------------------

The patch was applied

> FTP connection is not released If exception is thrown out of FtpFileObject.doGetOutputStream()
> ----------------------------------------------------------------------------------------------
>
>                 Key: VFS-289
>                 URL: https://issues.apache.org/jira/browse/VFS-289
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Kirill Safonov
>            Priority: Critical
>             Fix For: 2.0
>
>         Attachments: VFS-289.patch
>
>
> When the exception is thrown while getting file output stream (i.e. due to lack of write permissions), instance of FtpClient that wat obtained by {code}ftpFs.getClient(){code} is not put back to ftpFs, so this instance will never be called disconnect(). This effectively leads to the connection never released.
> This will eventually result in "FTP response 421 received. Server closed connection." due to too many open connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/VFS-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kirill Safonov closed VFS-289.
------------------------------


Verified and closed.

> FTP connection is not released If exception is thrown out of FtpFileObject.doGetOutputStream()
> ----------------------------------------------------------------------------------------------
>
>                 Key: VFS-289
>                 URL: https://issues.apache.org/jira/browse/VFS-289
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Kirill Safonov
>            Priority: Critical
>             Fix For: 2.0
>
>         Attachments: VFS-289.patch
>
>
> When the exception is thrown while getting file output stream (i.e. due to lack of write permissions), instance of FtpClient that wat obtained by {code}ftpFs.getClient(){code} is not put back to ftpFs, so this instance will never be called disconnect(). This effectively leads to the connection never released.
> This will eventually result in "FTP response 421 received. Server closed connection." due to too many open connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.